Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTEMS PSP using string literal for non-const char* #128

Closed
jphickey opened this issue Jan 9, 2020 · 0 comments · Fixed by #132
Closed

RTEMS PSP using string literal for non-const char* #128

jphickey opened this issue Jan 9, 2020 · 0 comments · Fixed by #132
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented Jan 9, 2020

Describe the bug
When setting up the network driver, the PC-RTEMS PSP is using string literals to assign char* data types. This triggers a warning when compiling with strict warnings.

To Reproduce
Build for PC-RTEMS using strict compiler settings, including -Wwrite-strings. Warnings are generated in cfe_psp_start.c.

Expected behavior
Should build cleanly.

System observed on:
Ubuntu 18.04 LTS 64-bit, building for i686-rtems 4.11 (pc-rtems)

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit that referenced this issue Jan 9, 2020
@jphickey
Fix #128: Do not directly use a literal for char* members
753a146 
Instead of directly using a literal, declare a static `char[]`
variable with the string and use that instead.
@jphickey jphickey mentioned this issue Jan 9, 2020
Merged
skliper added a commit that referenced this issue Jan 21, 2020
@skliper
Merge pull request #129 from nasa/fix-128-rtems-string-literal
e0ec90f 
Fix #128, Do not directly use a literal for char* members
@skliper skliper mentioned this issue Jan 21, 2020
Merged
@astrogeco astrogeco added this to the 1.5.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20200121 nasa/PSP
2 participants
@jphickey @astrogeco