Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PSP to use osal_id_t type instead of uint32 #200

Closed
jphickey opened this issue Oct 2, 2020 · 0 comments · Fixed by #201 or #206
Closed

Update PSP to use osal_id_t type instead of uint32 #200

jphickey opened this issue Oct 2, 2020 · 0 comments · Fixed by #201 or #206
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Oct 2, 2020

Is your feature request related to a problem? Please describe.
The osal_id_t typedef was recently added to OSAL to differentiate OSAL IDs from simple integers.

Describe the solution you'd like
PSP should use this type, instead of uint32, for all the places where an ID is stored.

Additional context
Using the typedef helps future-proof the code for possible ID type changes.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 2, 2020
@jphickey jphickey added the enhancement New feature or request label Oct 2, 2020
jphickey added a commit to jphickey/PSP that referenced this issue Oct 2, 2020
@jphickey
Fix nasa#200, Update PSP to use osal_id_t
0816003 
Use the osal_id_t typedef whenever dealing with an OSAL ID value.
@jphickey jphickey mentioned this issue Oct 2, 2020
Merged
astrogeco added a commit that referenced this issue Oct 12, 2020
@astrogeco
Merge pull request #201 from jphickey/fix-200-osal-id-type
b1e9057 
Fix #200, Update PSP to use osal_id_t
astrogeco added a commit to nasa/cFS that referenced this issue Oct 12, 2020
@astrogeco
Add nasa/PSP#200
68b8379
@astrogeco astrogeco mentioned this issue Oct 12, 2020
Merged
@astrogeco astrogeco modified the milestones: 2.0.0, 1.6.0 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #200, Update PSP to use osal_id_t jphickey/PSP
Integration Candidate 2020-10-13 nasa/PSP
2 participants
@jphickey @astrogeco