Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add static code analysis for pull requests #232

Closed
astrogeco opened this issue Jan 5, 2021 · 0 comments · Fixed by #233 or #234
Closed

Re-add static code analysis for pull requests #232

astrogeco opened this issue Jan 5, 2021 · 0 comments · Fixed by #233 or #234
Labels
bug Something isn't working continuous-integration
Milestone

Comments

@astrogeco
Copy link
Contributor

Describe the bug
The Travis CI runner ran cppcheck which we don't have anymore

To Reproduce
Submit pull request, notice that Travis CI doesn't run anymore.

Expected behavior
A success or failure report of a cppcheck run.

Code snips
Check from travis.yml

  # Check versions
  - cppcheck --version

  #cppcheck flight software psp/fsw
  - cppcheck --force --inline-suppr --std=c99 --language=c --error-exitcode=1 --enable=warning,performance,portability,style --suppress=variableScope --inconclusive fsw 2>cppcheck_flight_psp.txt
  - |
    if [[ -s cppcheck_flight_psp.txt ]]; then
      echo "You must fix cppcheck errors before submitting a pull request"
      echo ""
      cat cppcheck_flight_psp.txt
      exit -1
    fi
 

System observed on:
n/a

Additional context
Part of ongoing TravisCI to GitHub Actions migration

@astrogeco astrogeco added bug Something isn't working continuous-integration labels Jan 5, 2021
astrogeco added a commit to astrogeco/PSP that referenced this issue Jan 6, 2021
astrogeco added a commit that referenced this issue Jan 6, 2021
Fix #232, Re-add automated static code analysis
@astrogeco astrogeco added this to the 1.6.0 milestone Jan 6, 2021
astrogeco added a commit that referenced this issue Jan 7, 2021
Fix #232, Re-add automated static code analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working continuous-integration
Projects
None yet
1 participant