Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck 2.7 style warnings, constParameter #373

Closed
skliper opened this issue Jan 3, 2023 · 0 comments · Fixed by #374
Closed

cppcheck 2.7 style warnings, constParameter #373

skliper opened this issue Jan 3, 2023 · 0 comments · Fixed by #374
Assignees
@skliper
Labels
enhancement New feature or request
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Jan 3, 2023

Is your feature request related to a problem? Please describe.
From unrelated run: https://github.com/skliper/PSP/actions/runs/3830123523

severity location error id issue
style fsw/pc-linux/src/cfe_psp_memory.c:758 constParameter Parameter 'PtrToKernelSegment' can be declared with const
style fsw/pc-linux/src/cfe_psp_memory.c:758 constParameter Parameter 'SizeOfKernelSegment' can be declared with const

Describe the solution you'd like
Squash warnings

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper self-assigned this Jan 3, 2023
skliper added a commit to skliper/PSP that referenced this issue Jan 3, 2023
@skliper
Fix nasa#373, Squash constParameter warning in linux cfe_psp_memory.c
d6451e9
@skliper skliper mentioned this issue Jan 3, 2023
Merged
2 tasks
@skliper skliper added enhancement New feature or request and removed continuous-integration labels Jan 3, 2023
dzbaker added a commit that referenced this issue Jan 5, 2023
@dzbaker
Merge pull request #374 from skliper/fix373-constparameter_warning
aaa404c 
Fix #373, Squash constParameter warning in linux cfe_psp_memory.c
@dzbaker dzbaker mentioned this issue Jan 5, 2023
Merged
2 tasks
@dzbaker dzbaker closed this as completed in f5bdede Jan 5, 2023
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement New feature or request
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #373, Squash constParameter warning in linux cfe_psp_memory.c skliper/PSP
2 participants
@skliper @dmknutsen