Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub for mismatched function prototype/implementation parameter names #379

Closed
2 tasks done
thnkslprpt opened this issue Feb 24, 2023 · 0 comments · Fixed by #380
Closed
2 tasks done

Scrub for mismatched function prototype/implementation parameter names #379

thnkslprpt opened this issue Feb 24, 2023 · 0 comments · Fixed by #380

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
3 cases of mismatched parameter names between function prototypes and their implementations.
e.g.

int32 CFE_PSP_MemCpy(void *dest, const void *src, uint32 n);

int32 CFE_PSP_MemCpy(void *dst, const void *src, uint32 size)

Expected behavior
Mismatched parameter names can be confusing for maintenance and application programming. Best for them to match for the sake of code clarity.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Feb 24, 2023
dzbaker added a commit that referenced this issue Jan 5, 2024
…rototype-parameter-names

Fix #379, Align mismatched function prototype/implem. parameter names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant