Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few hand-written function names in printf strings could be updated to use __func__ #387

Closed
2 tasks done
thnkslprpt opened this issue Apr 8, 2023 · 0 comments · Fixed by #388
Closed
2 tasks done

Comments

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Apr 8, 2023

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
There are a few remaining locations in PSP that use hand-written function names in the printf() message strings.

Code snips

OS_printf("CFE_PSP_Restart is not implemented on this platform ( yet ! )\n");

OS_printf("CFE_PSP_Panic Called with error code = 0x%08X. Exiting.\n", (unsigned int)ErrorCode);

Expected behavior
Use the __func__ predefined identifier where possible to lower future dependencies to updating hand-written comments.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Apr 8, 2023
dmknutsen added a commit that referenced this issue Dec 14, 2023
…-to-use-__func__

Fix #387, Replace hand-written function names with __func__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant