Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #387, Replace hand-written function names with __func__ #388

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Apr 9, 2023

Checklist

Describe the contribution

Although the names of these functions are unlikely to change, it never hurts to lower dependence on hand-written comments that may need to be updated in the future. May as well use the functionality provided by the predefined identifiers if it's available.

Testing performed
GitHub CI actions all passing successfully and local cFS bundle tests confirm no issues.

Expected behavior changes
No change to behavior.

Contributor Info
Avi Weiss @thnkslprpt

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 11, 2023
@dmknutsen dmknutsen added CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 14, 2023
@dmknutsen dmknutsen merged commit 24849bb into nasa:main Dec 14, 2023
@thnkslprpt thnkslprpt deleted the fix-387-update-function-names-to-use-__func__ branch December 14, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A few hand-written function names in printf strings could be updated to use __func__
3 participants