Fix #382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
Mar 13, 2023
thnkslprpt
force-pushed
the
fix-382-replace-exit-1-with-exit-failure
branch
from
c856201
to
ad03fc8
Compare
thnkslprpt
force-pushed
the
fix-382-replace-exit-1-with-exit-failure
branch
from
ad03fc8
to
cdc524f
Compare
jphickey
approved these changes
May 4, 2023
skliper
reviewed
Dec 11, 2023
thnkslprpt
force-pushed
the
fix-382-replace-exit-1-with-exit-failure
branch
from
cdc524f
to
9a47a7e
Compare
thnkslprpt
force-pushed
the
fix-382-replace-exit-1-with-exit-failure
branch
from
9a47a7e
to
6ccf27b
Compare
skliper
approved these changes
Dec 12, 2023
skliper
added
the
CCB:Ready
|
@dzbaker Recommending CCB review/merge |
dmknutsen
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
exit(1)andexit(-1)replaced withEXIT_FAILUREmacro.Note: A single case was replaced with
EXIT_SUCCESSinCFE_PSP_DisplayUsage()- this call toexit()seems to be there simply to explicitly end execution of the function (it's avoidfunction) so I assume there is no difference between exiting with SUCCESS or FAILURE.Testing performed
GitHub CI actions all passing successfully.
Tested locally to confirm no change to test outcomes or coverage.
Expected behavior changes
No change to behavior.
The macros are more expressive and potentially more portable.
System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.
Contributor Info
Avi Weiss @thnkslprpt