-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #413, Add coverage tests for pc-rtems #414
Fix #413, Add coverage tests for pc-rtems #414
Conversation
I wasn't able to easily set up the context enough to test |
3900bc3
to
28909c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Apologies it took so long to get to a review. A few minor nits below and recommend a rebase on main and should be good to go!
Eventually it'd be nice to restructure slightly to split into separate executables like apps do it (same change for the VxWorks ut's), and separate the shared test from the VxWorks one but I recommend getting this PR in before tackling those restructuring changes. I can also help w/ the final few uncovered lines (although lets get this in first).
unit-test-coverage/pc-rtems/src/coveragetest-cfe-psp-exception.c
Outdated
Show resolved
Hide resolved
28909c9
to
5f24032
Compare
5f24032
to
3c11f3f
Compare
Recommending CCB review (and hopefully merge) so we can continue moving forward. Future work: Minor coverage improvements, add to CI and enforce (already #18), stub out shared APIs and cover those in their own test cases, individual exe per file. |
Checklist
Describe the contribution
Testing performed
GitHub CI actions all passing successfully and local testing results in the following added coverage for pc-rtems:
Expected behavior changes
No code changes - only adding new tests.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt