Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move table header definitions to table header #16

Closed
skliper opened this issue Apr 22, 2022 · 1 comment · Fixed by #62
Closed

Move table header definitions to table header #16

skliper opened this issue Apr 22, 2022 · 1 comment · Fixed by #62
Labels
draco-rc4 enhancement
Milestone
Draco

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

SC_RtsEntryHeader_t and SC_AtsEntryHeader_t are currently defined in sc_app.h:
https://aetd-git.gsfc.nasa.gov/gsfc-cfs/cfs_sc/-/blob/develop/fsw/src/sc_app.h#L306
https://aetd-git.gsfc.nasa.gov/gsfc-cfs/cfs_sc/-/blob/develop/fsw/src/sc_app.h#L330

Really should be owned by sc_tbldefs.h so that tables that use them don't need to include the entire sc_app.h.

Imported from GSFCCFS-1840
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Oct 24, 2022
@thnkslprpt
Fix nasa#16, Move Table Header definitions from sc_app.h to sc_tbldefs.h
cfb1b1e
@thnkslprpt thnkslprpt mentioned this issue Oct 24, 2022
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Nov 5, 2022
@thnkslprpt
Fix nasa#16, Move Table Header definitions from sc_app.h to sc_tbldefs.h
746aadd
thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Nov 5, 2022
@thnkslprpt
Fix nasa#16, Move Table Header definitions from sc_app.h to sc_tbldefs.h
d651f31
@jphickey
Copy link
Contributor

Meant to update #17 as a bug instead. (Similar but different issue)

dzbaker added a commit that referenced this issue Dec 15, 2022
@dzbaker
Merge pull request #62 from thnkslprpt/fix-16-move-table-header-defin…
7a69571 
…itions

Fix #16, Move Table Header definitions from sc_app.h to sc_tbldefs.h
@chillfig chillfig added this to the Draco milestone Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc4 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #16, Move Table Header definitions from sc_app.h to sc_tbldefs.h thnkslprpt/SC
3 participants
@jphickey @skliper @chillfig