Fix #101, add header update platform config #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new SC platform configuration option: SC_PLATFORM_SC_ENABLE_HEADER_UPDATE This option is translated to the UpdateHeader option of CFE_SB_TransmitMsg() - If set to "false" (default) this replicates current behavior. In this mode, commands within ATS/RTS tables are expected to be fully initialized, including all headers and checksums, and the message will be passed verbatim to the software bus. - If set to "true" (new option) this permits the commands to be timestamped and sequenced according to the real time system state. The headers will be updated as part of sending the message on the bus, and a valid checksum will be computed in real time. Note - There is currently no way to perform a checksum computation during table generation, so inserting a valid checksum within in ATS/RTS table entries is difficult when a robust checksum algorithm is used.
jphickey
force-pushed
the
fix-101-update-header
branch
from
1718eaa
to
bad8af3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
This adds a new SC platform configuration option:
SC_PLATFORM_SC_ENABLE_HEADER_UPDATE
This option is translated to the UpdateHeader option of CFE_SB_TransmitMsg()
If set to "false" (default) this replicates current behavior. In this mode, commands within ATS/RTS tables are expected to be fully initialized, including all headers and checksums, and the message will be passed verbatim to the software bus.
If set to "true" (new option) this permits the commands to be timestamped and sequenced according to the real time system state. The headers will be updated as part of sending the message on the bus, and a valid checksum will be computed in real time.
Fixes #101
Testing performed
Run unit tests
Build SC with configuration each way
Expected behavior changes
If configured as true, then headers on outgoing commands are updated in real time as the messages are sent to SB.
System(s) tested on
Debian
Additional context
This is critical if the message use a strong checksum, as there is currently no way to automatically compute this when generating the table.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.