Fix #80, Unit tests read past array bounds and general cleanup #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Also consolidated "result" asserts using modern APIs, removed low-value/high-maintenance checks on event string and type (ID is sufficient to confirm path).
Recommend a follow-on issue to replace the rest of the UtAssert_True uses.
Testing performed
CI (including coverage)
Expected behavior changes
Greatly reduced technical debt wrt unit tests (large reduction in lines, and consistent table initialization)
System(s) tested on
CI
Additional context
Note this should make the remaining bug fixes and updates easier, by reducing ut change overhead.
Could squash if CCB wants, just tried to break down the changes a little.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC