Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #48, define msgids via topicids #49

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

jphickey
Copy link
Collaborator

@jphickey jphickey commented Dec 7, 2023

Describe the contribution
The MsgID value is a conversion from TopicID

Fixes #48

Testing performed
Build and run tests

Expected behavior changes
None, topic IDs were chosen such that the resulting MsgIDs are the same when using default config

System(s) tested on
Debian

Additional context
Depends on nasa/cFE#2474

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

The MsgID value is a conversion from TopicID
@jphickey jphickey added the ccb:ready Pull request is ready for review label Dec 13, 2023
@dzbaker dzbaker added the CCB:FastTrack Change should get merged with priority, generally to correct a build breakage or other urgent issue label Dec 13, 2023
@dzbaker dzbaker merged commit b5694ec into nasa:main Dec 13, 2023
5 checks passed
@jphickey jphickey deleted the fix-48-topicids branch January 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:FastTrack Change should get merged with priority, generally to correct a build breakage or other urgent issue ccb:ready Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define and use Topic IDs instead of fixed Msg IDs
2 participants