Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SB "Send" command names that write to a file #1032

Closed
12 of 13 tasks
skliper opened this issue Nov 25, 2020 · 0 comments · Fixed by #1118 or #1150
Closed
12 of 13 tasks

Update SB "Send" command names that write to a file #1032

skliper opened this issue Nov 25, 2020 · 0 comments · Fixed by #1118 or #1150
Labels
enhancement refactor
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Nov 25, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
CFE_SB_SendRoutingInfoCmd_t, CFE_SB_SendPipeInfoCmd_t, CFE_SB_SendMapInfoCmd_t and the corresponding command codes actually write to a file. Send should indicate a request to send information on the software bus.

Describe the solution you'd like
Fix names to be consistent

  • CFE_SB_SEND_ROUTING_INFO_CC -> CFE_SB_WRITE_ROUTING_INFO_CC
  • CFE_SB_SendRoutingInfoCmd_t -> CFE_SB_WriteRoutingInfoCmd_t
  • CFE_SB_SendRoutingInfoCmd -> CFE_SB_WriteRoutingInfoCmd
  • CFE_SB_SendRtgInfo -> CFE_SB_WriteRtgInfo
  • CFE_SB_SEND_PIPE_INFO_CC -> CFE_SB_WRITE_PIPE_INFO_CC
  • CFE_SB_SendPipeInfoCmd_t -> CFE_SB_WritePipeInfoCmd_t
  • CFE_SB_SendPipeInfoCmd -> CFE_SB_WritePipeInfoCmd
  • CFE_SB_SendPipeInfo -> CFE_SB_WritePipeInfo*
  • CFE_SB_SEND_MAP_INFO_CC -> CFE_SB_WRITE_MAP_INFO_CC
  • CFE_SB_SendMapInfoCmd_t -> CFE_SB_WriteMapInfoCmd_t
  • CFE_SB_SendMapInfoCmd -> CFE_SB_WriteMapInfoCmd
  • CFE_SB_SendMapInfo -> CFE_SB_WriteMapInfo*
  • Will also need to update comments in Fix #982, separate pipeinfo file data structure #1102

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Jan 22, 2021
skliper added a commit to skliper/cFE that referenced this issue Jan 22, 2021
@skliper
Fix nasa#1032, Send->Write name update for SB write cmds
84dd36d
@skliper skliper mentioned this issue Jan 22, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jan 27, 2021
@skliper
Fix nasa#1032, Send->Write name update for SB write cmds
2db4b32
skliper added a commit to skliper/cFE that referenced this issue Jan 27, 2021
@skliper
Fix nasa#1032, Send->Write name update for SB write cmds
038ed40
astrogeco added a commit that referenced this issue Jan 27, 2021
@astrogeco
Merge pull request #1118 from skliper/fix1032-send_misnomer
e6cb6a3 
Fix #1032, Send->Write name update for SB write cmds
astrogeco added a commit that referenced this issue Jan 27, 2021
@astrogeco
Merge pull request #1118 from skliper/fix1032-send_misnomer
739181c 
Fix #1032, Send->Write name update for SB write cmds
astrogeco added a commit that referenced this issue Feb 3, 2021
@astrogeco
Merge pull request #1118 from skliper/fix1032-send_misnomer
b7358d2 
Fix #1032, Send->Write name update for SB write cmds
@astrogeco astrogeco mentioned this issue Feb 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement refactor
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco