Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto increment sequence on CMD packets #1157

Closed
jphickey opened this issue Feb 5, 2021 · 1 comment · Fixed by #2336
Closed

Auto increment sequence on CMD packets #1157

jphickey opened this issue Feb 5, 2021 · 1 comment · Fixed by #2336
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 5, 2021

Is your feature request related to a problem? Please describe.
The CFE_SB_TransmitMsg() function has a boolean parameter to indicate if the sequence number should be incremented automatically based on the route. This route-based sequence number overrides whatever was in the buffer.

However, this only works on telemetry packets. There is a test that checks specifically if the packet is TLM, and only updates the sequence number if so.

This means that all locally-generated messages of the "CMD" variety - which includes the various TIME messages e.g. 1Hz, and all "SEND_HK" packets generated by SCH - always have a sequence number of 0 in their header.

Describe the solution you'd like
The sequence number should probably be valid on all these - otherwise there is no way to tell if a message was missed.

Additional context
It is not clear why only locally-generated TLM packets would have a valid sequence, but not locally-generated CMD packets.

Note SCH_LAB currently calls CFE_SB_TransmitMsg() with the value set false -- so this would have to change too in order to get valid sequence numbers in SEND_HK packets.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Feb 5, 2021
@jphickey
Copy link
Contributor Author

jphickey commented Feb 5, 2021

Assuming agreement here - its only a one-line change to remove the check which limits this to TLM packets. But my previous PR #1154 affects it so should wait for that one to get merged before fixing this.

jphickey added a commit to jphickey/cFE that referenced this issue Apr 1, 2021
Do not restrict sequence increment to TLM only, since
CMD packets can be locally generated too (e.g. SCH, TIME).
jphickey added a commit to jphickey/cFE that referenced this issue Apr 1, 2021
Do not restrict sequence increment to TLM only, since
CMD packets can be locally generated too (e.g. SCH, TIME).
@astrogeco astrogeco added this to the cFS-Draco milestone Aug 10, 2021
@skliper skliper removed this from the Draco milestone Mar 18, 2022
@dzbaker dzbaker added this to the Equuleus milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants