Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printf test logs missing last character #1763

Closed
jphickey opened this issue Aug 4, 2021 · 0 comments · Fixed by #1764 or #1772
Closed

Printf test logs missing last character #1763

jphickey opened this issue Aug 4, 2021 · 0 comments · Fixed by #1764 or #1772
Assignees
Labels
Milestone

Comments

@jphickey
Copy link
Contributor

jphickey commented Aug 4, 2021

Describe the bug
In the CFE coverage tests, assertions for "printf" include the message format string being checked for, but it truncates the last character. For example:

[ PASS] 02.006 es_UT.c:724 - Printf generated: '%s: Startup Sync failed - Applications may not have all starte' (1) >  (0)
[ PASS] 02.007 es_UT.c:725 - Printf generated: '%s: Startup Sync failed - Applications may not have all initialize' (1) >  (0)

To Reproduce
Run ES coverage test, view logs

Expected behavior
Should include the full string, not cut off the last char.

System observed on:
Ubuntu

Additional context
Off by one error in the string processing

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Aug 4, 2021
@jphickey jphickey added the bug label Aug 4, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 4, 2021
The "MessageCheck_Impl" routine used for printf/syslog checks
was incorrectly truncating the last character of the log message.
jphickey added a commit to jphickey/cFE that referenced this issue Aug 4, 2021
The "MessageCheck_Impl" routine used for printf/syslog checks
was incorrectly truncating the last character of the log message.
astrogeco added a commit that referenced this issue Aug 9, 2021
Fix #1763, last char truncated in coverage log output
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants