Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE_ES_POOL_BOUNDS_ERROR defined but not used #1850

Closed
jphickey opened this issue Aug 19, 2021 · 0 comments · Fixed by #1853 or #1839
Closed

CFE_ES_POOL_BOUNDS_ERROR defined but not used #1850

jphickey opened this issue Aug 19, 2021 · 0 comments · Fixed by #1853 or #1839
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This error code was added at one point as a return value from CFE_ES_PoolCreateEx when there was an issue that caused the pool to go beyond the allocated size. However now the code validates the size before even starting to create the pool, and returns CFE_ES_BAD_ARGUMENT if it is too small.

So now the CFE_ES_POOL_BOUNDS_ERROR has become stale, nothing uses this error anymore.

Describe the solution you'd like
Remove value from cfe_error.h and remove any remaining references to it.

Additional context
Noted as part of scrub in #1724

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Aug 19, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 19, 2021
Stale error code no longer produced by implementation
jphickey added a commit to jphickey/cFE that referenced this issue Aug 19, 2021
Stale error code no longer produced by implementation
astrogeco added a commit that referenced this issue Aug 20, 2021
Fix #1850, remove unused CFE_ES_POOL_BOUNDS_ERROR
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants