Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE_TBL_ERR_BAD_APP_ID error defined but not used #1851

Closed
jphickey opened this issue Aug 19, 2021 · 0 comments · Fixed by #1854 or #1839
Closed

CFE_TBL_ERR_BAD_APP_ID error defined but not used #1851

jphickey opened this issue Aug 19, 2021 · 0 comments · Fixed by #1854 or #1839
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This error code was added at one point as a return value from various TBL API calls when they were called from a context which was not a CFE APP. However, in the current code, the status code from the call to CFE_ES_GetAppID() is just passed through:

Status = CFE_ES_GetAppID(AppIdPtr);
if (Status != CFE_SUCCESS)
{
return Status;
}

As a result, nothing actually returns CFE_TBL_ERR_BAD_APP_ID in the current code.

Describe the solution you'd like
Remove value from cfe_error.h and remove any remaining references to it.

As the value is passed through from CFE_ES_GetAppID(), the actual return code when called from a bad context is CFE_ES_ERR_RESOURCEID_NOT_VALID.

Additional context
Noted as part of scrub in #1724

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Aug 19, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 19, 2021
Status code no longer produced by current implementation, it passes
through the ES error which will be CFE_ES_ERR_RESOURCEID_NOT_VALID.
astrogeco added a commit that referenced this issue Aug 20, 2021
Fix #1851, remove unused CFE_TBL_ERR_BAD_APP_ID
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants