Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing test cases for file services API parameter/return combinations #1867

Closed
jphickey opened this issue Aug 23, 2021 · 0 comments · Fixed by #1871 or #1885
Closed

Missing test cases for file services API parameter/return combinations #1867

jphickey opened this issue Aug 23, 2021 · 0 comments · Fixed by #1871 or #1885
Assignees
@jphickey
Labels
enhancement functional unit-test
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The following parameter/return code combinations are not exercised by the file services functional test:

  + condition: CFE_FS_ExtractFilenameFromPath[any]=>CFE_FS_FNAME_TOO_LONG
  + condition: CFE_FS_ExtractFilenameFromPath[any]=>CFE_FS_INVALID_PATH
  + condition: CFE_FS_SetTimestamp[any]=>CFE_STATUS_EXTERNAL_RESOURCE_FAIL

Describe the solution you'd like
Solve each missing case in one of three ways:

  1. Add a test case covering that option
  2. Update the API documentation
  3. Add a @covtest tag if the combination can only be reasonably achieved in a coverage environment

Additional context
Part of/related to #1724 (each subsystem will be handled separately)

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Aug 23, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 23, 2021
@jphickey
Fix nasa#1867, Add FS API test cases
19e5f2f 
Adds FS functional test cases to cover all missing items that
were identified as part of the scrub in issue nasa#1724.

Where a specific condition is not testable because it requires
a failure of another subsystem, it is marked as `covtest` to
indicate it is only verifiable in coverage test environment.
@jphickey jphickey mentioned this issue Aug 23, 2021
Merged
astrogeco added a commit that referenced this issue Aug 24, 2021
@astrogeco
Merge pull request #1871 from jphickey/fix-1867-fs-testcases
ea38fd2 
Fix #1867, Add FS API test cases
@astrogeco astrogeco mentioned this issue Aug 25, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement functional unit-test
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #1867, Add FS API test cases jphickey/cFE
cFE Integration candidate: 2021-08-31 nasa/cFE
2 participants
@jphickey @skliper