Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older versions of make do not support "abspath" #2423

Closed
jphickey opened this issue Aug 10, 2023 · 0 comments · Fixed by #2424
Closed

Older versions of make do not support "abspath" #2423

jphickey opened this issue Aug 10, 2023 · 0 comments · Fixed by #2424

Comments

@jphickey
Copy link
Contributor

Describe the bug
The table build procedure uses the GNU make function $(abspath <file>) as documented here: https://www.gnu.org/software/make/manual/html_node/File-Name-Functions.html#index-abspath-1

However, older versions of make (e.g. 3.8) appear to not support this function as described - although make itself does not throw an error about this function, the result is an empty string. This in turn causes the command being executed to fail because its missing the argument, which is supposed to be a file name.

To Reproduce
Build the software using an older version of GNU make, an error such as this occurs:

cd elf/lx_es1_stub/ && /usr/bin/ar x  cfe_test_tbl.c.o
/usr/bin/ar: cfe_test_tbl.c.o: No such file or directory

Expected behavior
There should be a library filename between the "x" and the object filename.

Code snips
The command in the makefile here is:

cd $(dir $(@)) && $(AR) x $(abspath $(<)) $(notdir $(@))

Note that the $(abspath $(<)) evaluated to the empty string. Whereas on GNU make 4.x this works as described in the documentation.

System observed on:
VxWorks 6.9, which ships a binary version of GNU make v3.8.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the bug label Aug 10, 2023
github-actions bot pushed a commit that referenced this issue Aug 15, 2023
Fix #2423, avoid use of abspath make function
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants