Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename time 1HZ signal to ONEHZ #2475

Closed
jphickey opened this issue Dec 7, 2023 · 0 comments · Fixed by #2474
Closed

Rename time 1HZ signal to ONEHZ #2475

jphickey opened this issue Dec 7, 2023 · 0 comments · Fixed by #2474

Comments

@jphickey
Copy link
Contributor

jphickey commented Dec 7, 2023

Is your feature request related to a problem? Please describe.
In some environments, the CFE_TIME_ namespace prefix is not used.

When this prefix is removed from the 1HZ related identifiers (e.g. CFE_TIME_1HZ_CMD_MID) then one will be left with just 1HZ_CMD_MID ... and this is not a valid identifier in many contexts because it starts with a digit.

Describe the solution you'd like
Problem could be avoided if simply renamed to ONEHZ instead of 1HZ.

Additional context
This is really the only remaining symbol that has this concern, and its trivial to replace it. Can keep the old name as a deprecated symbol for backward compatibility.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/cFE that referenced this issue Dec 7, 2023
This avoids having an identifier that starts with a digit
in the case that the CFE_TIME_ prefix is not needed/used.
@jphickey jphickey linked a pull request Dec 7, 2023 that will close this issue
2 tasks
jphickey added a commit to jphickey/cFE that referenced this issue Dec 7, 2023
This avoids having an identifier that starts with a digit
in the case that the CFE_TIME_ prefix is not needed/used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant