Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #2610

Open
thnkslprpt opened this issue Oct 11, 2024 · 0 comments · May be fixed by #2611
Open

Enforce keeping coverage minimums up-to-date in Code Coverage CI workflow #2610

thnkslprpt opened this issue Oct 11, 2024 · 0 comments · May be fixed by #2611

Comments

@thnkslprpt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Code coverage minimums seem to go out-of-date quite often - like right now, where the missed-lines minimum is higher than necessary.

When these values aren't updated, the code coverage workflow will pass and it's likely that no alert will occur if a new PR reduces test coverage.

Describe the solution you'd like
Fail the code coverage workflow if a PR improves coverage but hasn't updated (lowered) the missed functions/lines/branches variables in the workflow file.

Similar to OSAL:

Describe alternatives you've considered
Leave as-is and check periodically that these minimum coverage variables are still up-to-date.

Requester Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant