Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs missing check for NULL pointer(s) #547

Closed
dmknutsen opened this issue Mar 10, 2020 · 0 comments · Fixed by #1140 or #1196
Closed

APIs missing check for NULL pointer(s) #547

dmknutsen opened this issue Mar 10, 2020 · 0 comments · Fixed by #1140 or #1196
Assignees
Milestone

Comments

@dmknutsen
Copy link
Contributor

Describe the bug
There are a number of APIs that do not currently check to see if a NULL pointer has been passed in as an input argument. We should consider adding the additional check in the following APIs:

cfe_es_api.c:CFE_ES_CalculateCRC
cfe_es_api.c:CFE_ES_CopyToCDS
cfe_es_api.c:CFE_ES_CreateChildTask
cfe_es_api.c:CFE_ES_GetAppID
cfe_es_api.c:CFE_ES_GetAppName
cfe_es_api.c:CFE_ES_GetGenCounterIDByName
cfe_es_api.c:CFE_ES_GetTaskInfo
cfe_es_api.c:CFE_ES_ProcessCoreException
cfe_es_api.c:CFE_ES_RegisterCDS
cfe_es_api.c:CFE_ES_RestoreFromCDS
cfe_es_api.c:CFE_ES_RunLoop
cfe_es_api.c:CFE_ES_WriteToSysLog
cfe_esmempool.c:CFE_ES_GetMemPoolStats
cfe_esmempool.c:CFE_ES_GetPoolBuf
cfe_esmempool.c:CFE_ES_GetPoolBufInfo
cfe_esmempool.c:CFE_ES_PoolCreate
cfe_esmempool.c:CFE_ES_PoolCreateEx
cfe_esmempool.c:CFE_ES_PoolCreateNoSem
cfe_esmempool.c:CFE_ES_PutPoolBuf
cfe_evs.c:CFE_EVS_SendEvent
cfe_evs.c:CFE_EVS_SendEventWithAppID
cfe_evs.c:CFE_EVS_SendTimedEvent
cfe_fs_api.c:CFE_FS_InitHeader
cfe_fs_api.c:CFE_FS_ReadHeader
cfe_fs_api.c:CFE_FS_SetTimestamp
cfe_fs_api.c:CFE_FS_WriteHeader
cfe_sb_api.c:CFE_SB_CreatePipe
cfe_sb_api.c:CFE_SB_ZeroCopyGetPtr
cfe_sb_msg_id_util.c:CFE_SB_GetMsgId
cfe_sb_msg_id_util.c:CFE_SB_SetMsgId
cfe_sb_util.c:CFE_SB_GenerateChecksum
cfe_sb_util.c:CFE_SB_GetChecksum
cfe_sb_util.c:CFE_SB_GetCmdCode
cfe_sb_util.c:CFE_SB_GetMsgTime
cfe_sb_util.c:CFE_SB_GetTotalMsgLength
cfe_sb_util.c:CFE_SB_GetUserData
cfe_sb_util.c:CFE_SB_GetUserDataLength
cfe_sb_util.c:CFE_SB_InitMsg
cfe_sb_util.c:CFE_SB_MessageStringGet
cfe_sb_util.c:CFE_SB_MessageStringSet
cfe_sb_util.c:CFE_SB_MsgHdrSize
cfe_sb_util.c:CFE_SB_SetCmdCode
cfe_sb_util.c:CFE_SB_SetMsgTime
cfe_sb_util.c:CFE_SB_SetTotalMsgLength
cfe_sb_util.c:CFE_SB_SetUserDataLength
cfe_sb_util.c:CFE_SB_TimeStampMsg
cfe_sb_util.c:CFE_SB_ValidateChecksum
cfe_tbl_api.c:CFE_TBL_GetAddress
cfe_tbl_api.c:CFE_TBL_GetAddresses
cfe_tbl_api.c:CFE_TBL_GetInfo
cfe_tbl_api.c:CFE_TBL_Load
cfe_tbl_api.c:CFE_TBL_Register
cfe_tbl_api.c:CFE_TBL_Share
cfe_time_api:CFE_TIME_Print
cfe_time_api:CFE_TIME_RegisterSynchCallback

System observed on:
NA - Code review/audit

Reporter Info
Dan Knutsen
NASA Goddard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants