Fix #1036, Clear task data in EarlyInit and standardize name #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
cFE Integration candidate: 2021-01-19
skliper
force-pushed
the
fix1036-clear_globals
branch
from
cb84069
to
291fcdb
Compare
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
skliper
force-pushed
the
fix1036-clear_globals
branch
from
291fcdb
to
cf198f6
Compare
|
Rebased and updated SB global name (finished work). |
|
CCB:2021-01-27 APPROVED
|
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 27, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 3, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1036 - explicity memset the task data to zero at the start of EarlyInit. Also standardizes the global typdef/variable names.
Might need a rebase based on the name changes.
Testing performed
Build and run unit tests, passed.
Expected behavior changes
None.
System(s) tested on
Additional context
TBL global depends on
CFE_TBL_Global.TableTaskAppIdbeing set, which doesn't happen until the app starts (inCFE_TBL_InitData), so replaced where CFE_TBL_EarlyInit was being called to initialize the data with the test initialization functionTest_CFE_TBL_ApiInit. In the future these tests could be cleaned up by calling the initialization before each test, and ensuring there are no test configuration dependencies across tests.Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC