Fix #1108, split resource id functions into module #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all functions, macros, types, and other definitions related to resource IDs and generic resource management into a separate module, like CFE MSG and SBR, etc. Notably this allows a mission to elect "strict" implementations of these objects, where every ID type is unique, and assigning between them (or uint32) results in a compiler error.
jphickey
added
the
CCB:Ready
astrogeco
added
CCB:2021-01-27
and removed
CCB:Ready
CCB 2021-01-27 APPROVEDDoesn't change the API but now uses the correct type. |
Remove code blocks that were commented out, not needed.
|
FYI - just added another commit here to remove some |
|
@jphickey check conflicts |
jphickey
added a commit
that referenced
this pull request
Feb 8, 2021
Fix #1108, split resource id functions into module
jphickey
added a commit
to nasa/cFS
that referenced
this pull request
Feb 8, 2021
jphickey
added a commit
that referenced
this pull request
Feb 8, 2021
Corrects warnings/errors in doxygen userguide
jphickey
added a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Move all functions, macros, types, and other definitions related to resource IDs and generic resource management into
a separate module, like CFE MSG and SBR, etc.
Notably this allows a mission to elect "strict" implementations of these objects, where every ID type is unique, and assigning
between them (or uint32) results in a compiler error.
Fixes #1108
Fixes #913
Testing performed
Build and sanity test CFE, run all unit tests
Expected behavior changes
API now has separate types for each resource type (Apps, Tasks, Libs, Counters, etc).
System(s) tested on
Ubuntu 20.04
Additional context
The user can elect at the mission level whether this is a simple typedef (all
uint32, all interchangeable) or a wrapper type (separate/strict type, cannot be interchanged). The former is backward compatible but the latter is not - must use proper types.Default if nothing is indicated is to use the backward compatible types, of course - so this doesn't break anyone's build.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.