Fix #1346, error if alignment size not a power of two #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Instead of "fixing" the alignment mask, return an error if the passed-in value is not actually a power of two.
Fixes #1346
Testing performed
Build and sanity test CFE, run all unit tests
Expected behavior changes
Function will return
CFE_ES_BAD_ARGUMENT
if the passed in parameter is not a power of two.System(s) tested on
Ubuntu 20.04
Additional context
This is an internal functions, and in ES this only gets passed from two possible sources: one is CDS, hardcoded as 4, and the other is sourced from the ALIGN_OF macro for generic memory pools.
The latter is platform-dependent but I've never seen a platform that aligns data on something other than a power of two boundary.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.