Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1831, Consolidate msg get/set doxygen group #1832

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix #1831, Consolidate msg get/set doxygen group #1832

merged 1 commit into from
Aug 19, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 17, 2021

Describe the contribution
Fix #1831
Makes one group for SB Message Characteristics (get/set combined). Note the setter name was also out of family (didn't include SB).

Testing performed
CI - doc only

Expected behavior changes
None

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 17, 2021
@skliper skliper added this to the 7.0.0 milestone Aug 17, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation. and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 18, 2021
@astrogeco
Copy link
Contributor

CCB:2021-08-18 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate August 19, 2021 13:59
@astrogeco astrogeco merged commit f1a8f74 into nasa:integration-candidate Aug 19, 2021
@astrogeco astrogeco mentioned this pull request Aug 19, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 19, 2021
@astrogeco
nasa/cFE#1833, Clean up Message ID Functional Test #1824, Add missing…
715188e 
… cases for msg id func tests

nasa/cFE#1832, Combine SB Set/Get message characteristics group #1831, Consolidate msg get/set doxygen group
@astrogeco astrogeco mentioned this pull request Aug 19, 2021
Merged
2 tasks
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 20, 2021
@astrogeco
nasa/cFE#1833, Clean up Message ID Functional Test #1824, Add missing…
2912571 
… cases for msg id func tests

nasa/cFE#1832, Combine SB Set/Get message characteristics group #1831, Consolidate msg get/set doxygen group
astrogeco added a commit to nasa/cFS that referenced this pull request Aug 21, 2021
@astrogeco @skliper
@jphickey @zanzaben @nmullane @ArielSAdamsNASA @pepepr08
IC:2021-08-24, cFE and osal
ae326c7 
**Combines**

nasa/cFE# v6.8.0-rc1+dev933
nasa/osal# v5.1.0-rc1+dev594

**Includes**

*osal*

nasa/osal#1131, add test case types similar to NA

*cFE*

nasa/cFE#1803, Add software bus tests
nasa/cFE#1756, separate variable for OSAL status
nasa/cFE#1809, increase SB pool max size bucket
nasa/cFE#1842, Add Null check for CFE_ResourceId_FindNext
nasa/cFE#1828, Improve TBL coverage tests
nasa/cFE#1833, Clean up Message ID Functional Test #1824, Add missing cases for msg id func tests
nasa/cFE#1832, Combine SB Set/Get message characteristics group #1831, Consolidate msg get/set doxygen group
nasa/cFE#1836, Adding coverage tests to cFE TIME
nasa/cFE#1848, enable strict resource id w/OMIT_DEPRECATED
nasa/cFE#1845, HOTFIX IC-20210819, type correction TBL coverage test
nasa/cFE#1806, Add test for ES BackgroundWakeup
nasa/cFE#1813, Success Test for CFE_ES_RestartApp
nasa/cFE#1814, Subscribe to Message Limit Greater Than CFE_PLATFORM_SB_DEFAULT_MSG_LIMIT
nasa/cFE#1811, Success Test for CFE_ES_GetMemPoolStats
nasa/cFE#1822, Group MSG APIs documentation by header type
nasa/cFE#1816, add retroactive CFE status asserts
nasa/cFE#1854, remove unused CFE_TBL_ERR_BAD_APP_ID
nasa/cFE#1855, correct syslog message in pool create
nasa/cFE#1853, remove unused CFE_ES_POOL_BOUNDS_ERROR
nasa/cFE#1859, remove unused CFE_TBL_ERR_FILE_NOT_FOUND
nasa/cFE#1856, Check error ctr to TransmitMsg test
nasa/cFE#1857, End Child Task requirement remove error code
nasa/cFE#1782, Add functional tests for resource misc

Co-authored-by: Jacob Hageman           <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey           <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell           <zanzaben@users.noreply.github.com>
Co-authored-by: Niall Mullane           <nmullane@users.noreply.github.com>
Co-authored-by: Ariel Adams             <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
@skliper skliper deleted the fix1831-sb_dox_groups branch October 22, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanzaben zanzaben zanzaben approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation.
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Combine SB Set/Get message characteristics group
3 participants
@skliper @astrogeco @zanzaben