Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2054, Missing SB include for v2 msgid #2056

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Feb 23, 2022

Describe the contribution

Testing performed
Stand alone build and CI

Expected behavior changes
Clean V2 build (see details in #2054)

System(s) tested on

  • Hardware: i5/wsl2
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Feb 23, 2022
@skliper skliper added this to the Draco milestone Feb 23, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Feb 23, 2022
@astrogeco
Copy link
Contributor

astrogeco commented Feb 23, 2022

CCB:2022-02-23 APPROVED

  • open issue to test in CI?
  • deprecate or refactor v2 msgids?

astrogeco added a commit to nasa/cFS that referenced this pull request Feb 25, 2022
nasa/cFE#2056, Missing SB include for v2 msgid

nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI
astrogeco added a commit that referenced this pull request Feb 25, 2022
Part of IC:Caelum+dev4, nasa/cFS#432

**Includes**

PR #2056
- Missing SB include for v2 msgid

PR #2052
- Resolve doxygen doc warnings and enforce in CI

PR #2050
- Remove explicit filename doxygen comments

PR #2048
- Add CFE_ES_CreateChildTask default handler
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 25, 2022
**Combines**

- nasa/cFE#2061, v7.0.0-rc4+dev80
- nasa/osal#1226, v6.0.0-rc4+dev42
- nasa/PSP#326, v1.6.0-rc4+dev14

*Apps*
- ci_lab v2.5.0-rc4+dev10
- sample_app v1.3.0-rc4+dev9
- sch_lab v2.5.0-rc4+dev16
- to_lab v2.5.0-rc4+dev9

*Libs*
- sample_lib v1.3.0-rc4+dev9

*Tools*
- cFS-GroundSystem v3.0.0-rc4+dev12
- elf2cfetbl v3.3.0-rc4+dev11
- tblCRCTool v1.3.0-rc4+dev7

**Includes**

- nasa/cFE#2048, Add CFE_ES_CreateChildTask default handler

- nasa/osal#1215, Resolve UT uninitialized variable warnings

- nasa/osal#1219, Add ut_assert to doxygen and fix warnings

- nasa/osal#1223, protect if OS_FDGetInfo called on socket

- nasa/cFE#2056, Missing SB include for v2 msgid

- nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI

*Apply Header Guard Standard*

- nasa/PSP#322

- nasa/ci_lab#103
- nasa/to_lab#114
- nasa/sch_lab#107

- nasa/sample_lib#74

- nasa/elf2cfetbl#100
- nasa/cFS-GroundSystem#205

*Remove explicit filename doxygen comments*

- nasa/cFE#2050
- nasa/osal#1217
- nasa/PSP#324

- nasa/sample_lib#76

- nasa/tblCRCTool#62
- nasa/elf2cfetbl#102
@astrogeco astrogeco merged commit c6ded42 into nasa:main Feb 25, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 25, 2022
**Combines**

- nasa/cFE#2061, v7.0.0-rc4+dev80
- nasa/osal#1226, v6.0.0-rc4+dev42
- nasa/PSP#326, v1.6.0-rc4+dev14

*Apps*
- ci_lab v2.5.0-rc4+dev10
- sample_app v1.3.0-rc4+dev9
- sch_lab v2.5.0-rc4+dev16
- to_lab v2.5.0-rc4+dev9

*Libs*
- sample_lib v1.3.0-rc4+dev9

*Tools*
- cFS-GroundSystem v3.0.0-rc4+dev12
- elf2cfetbl v3.3.0-rc4+dev11
- tblCRCTool v1.3.0-rc4+dev7

**Includes**

- nasa/cFE#2048, Add CFE_ES_CreateChildTask default handler

- nasa/osal#1215, Resolve UT uninitialized variable warnings

- nasa/osal#1219, Add ut_assert to doxygen and fix warnings

- nasa/osal#1223, protect if OS_FDGetInfo called on socket

- nasa/cFE#2056, Missing SB include for v2 msgid

- nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI

*Apply Header Guard Standard*

- nasa/PSP#322

- nasa/ci_lab#103
- nasa/to_lab#114
- nasa/sch_lab#107

- nasa/sample_lib#74

- nasa/elf2cfetbl#100
- nasa/cFS-GroundSystem#205

*Remove explicit filename doxygen comments*

- nasa/cFE#2050
- nasa/osal#1217
- nasa/PSP#324

- nasa/sample_lib#76

- nasa/tblCRCTool#62
- nasa/elf2cfetbl#102
astrogeco added a commit to nasa/cFS that referenced this pull request Feb 25, 2022
**Combines**

- nasa/cFE#2061, v7.0.0-rc4+dev80
- nasa/osal#1226, v6.0.0-rc4+dev42
- nasa/PSP#326, v1.6.0-rc4+dev14

*Apps*
- ci_lab v2.5.0-rc4+dev10
- sample_app v1.3.0-rc4+dev9
- sch_lab v2.5.0-rc4+dev16
- to_lab v2.5.0-rc4+dev9

*Libs*
- sample_lib v1.3.0-rc4+dev9

*Tools*
- cFS-GroundSystem v3.0.0-rc4+dev12
- elf2cfetbl v3.3.0-rc4+dev11
- tblCRCTool v1.3.0-rc4+dev7

**Includes**

- nasa/cFE#2048, Add CFE_ES_CreateChildTask default handler

- nasa/osal#1215, Resolve UT uninitialized variable warnings

- nasa/osal#1219, Add ut_assert to doxygen and fix warnings

- nasa/osal#1223, protect if OS_FDGetInfo called on socket

- nasa/cFE#2056, Missing SB include for v2 msgid

- nasa/cFE#2052, Resolve doxygen doc warnings and enforce in CI

*Apply Header Guard Standard*

- nasa/PSP#322

- nasa/ci_lab#103
- nasa/to_lab#114
- nasa/sch_lab#107

- nasa/sample_lib#74

- nasa/elf2cfetbl#100
- nasa/cFS-GroundSystem#205

*Remove explicit filename doxygen comments*

- nasa/cFE#2050
- nasa/osal#1217
- nasa/PSP#324

- nasa/sample_lib#76

- nasa/tblCRCTool#62
- nasa/elf2cfetbl#102

Co-authored-by: Jacob Hageman   <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey   <jphickey@users.noreply.github.com>
@skliper skliper deleted the fix2054-msgid_include branch April 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link error when building with MISSION_MSGID_V2 = TRUE
2 participants