Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1497, Use CFE_TIME_SysTime_t instead of indiv. sec/subsec members #2246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Feb 17, 2023

Checklist

Describe the contribution

Testing performed
All tests were passing before changes to CFE_FS_Header_t were added (see https://github.com/nasa/cFE/actions/runs/4585928750 and https://github.com/nasa/cFE/actions/runs/4585928751).
The functional test and CodeQL analyses are no longer able to build because elf2cfetbl references the old uint32 members in CFE_FS_Header_t directly, so an additional PR for elf2cfetbl is required at the same time - see nasa/elf2cfetbl#134.
Local tests with full cFS package confirm all tests passing when both changes are made together, and net coverage unaffected.
Screenshot 2023-04-03 09 35 59
Screenshot 2023-04-03 09 35 33

Note: If this is merged it will require updates to some of the txt files in the Ground System tool to ensure clean and correct interpretation of the data members.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Expected behavior changes
No change to behavior.

Contributor Info
Avi Weiss @thnkslprpt

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found 1905 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

@thnkslprpt thnkslprpt force-pushed the fix-1497-use-CFE_TIME_SysTime_t branch from ec60708 to ff57c16 Compare March 24, 2024 01:07
@thnkslprpt
Copy link
Contributor Author

Partially implemented in #2544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CFE_TIME_SysTime_t instead of individual Seconds/subseconds
1 participant