-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #921, Update remaining cFE source/tests to use CFE_Status_t #2264
base: main
Are you sure you want to change the base?
Fix #921, Update remaining cFE source/tests to use CFE_Status_t #2264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
da32d56
to
53fc364
Compare
You have successfully added a new CodeQL configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
You have successfully added a new CodeQL configuration |
53fc364
to
6d7bca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
6d7bca9
to
af9e96d
Compare
74c5e58
to
33807fe
Compare
33807fe
to
a53a43a
Compare
Checklist
Describe the contribution
int32
return types converted toCFE_Status_t
.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to behavior/logic-
CFE_Status_t
is currently typedef'd toint32
, so no functional change to any types with this PR.Synchronizing the return types to
CFE_Status_t
simplifies the code, and makes it more type-safe.Contributor Info
Avi Weiss @thnkslprpt