Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #921, Update remaining cFE source/tests to use CFE_Status_t #2264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 25, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No change to behavior/logic- CFE_Status_t is currently typedef'd to int32, so no functional change to any types with this PR.
Synchronizing the return types to CFE_Status_t simplifies the code, and makes it more type-safe.

Contributor Info
Avi Weiss @thnkslprpt

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL-coding-standard found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@thnkslprpt thnkslprpt force-pushed the fix-921-update-remaining-cfe-code-to-use-cfe-status-t branch from da32d56 to 53fc364 Compare March 31, 2023 04:29
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found 1905 existing alerts. Please check the repository Security tab to see all alerts.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@thnkslprpt thnkslprpt force-pushed the fix-921-update-remaining-cfe-code-to-use-cfe-status-t branch from 6d7bca9 to af9e96d Compare March 24, 2024 00:58
@thnkslprpt thnkslprpt force-pushed the fix-921-update-remaining-cfe-code-to-use-cfe-status-t branch 3 times, most recently from 74c5e58 to 33807fe Compare April 20, 2024 23:13
@thnkslprpt thnkslprpt force-pushed the fix-921-update-remaining-cfe-code-to-use-cfe-status-t branch from 33807fe to a53a43a Compare April 21, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update cFE source and unit tests to use CFE_Status_t
1 participant