Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #399, Deprecate decompress #638

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 24, 2020

Describe the contribution
Fix #399
Removes untraced capabilities to decompress libraries or
apps on load. For non-startup apps, FS can be used. For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.

Fix #291
By deprecating decompress it can be moved to the FS app.

Fix #135
Static code analysis issues in decompress now N/A

Testing performed
Steps taken to test the contribution:

  1. Standard build with and without code deprecated, SIMULATION=native, ENABLE_UNIT_TESTS=true

Expected behavior changes
No longer automatically decompresses apps/libraries as part of load

System(s) tested on

  • Hardware: cFS Dev Server 3
  • OS: Ubuntu 18.04
  • Versions: Master bundle + this commit

Additional context
FS app updates will add decompress functionality, and decompress is planned to be implemented as a replaceable library

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 24, 2020
@skliper skliper added this to the 6.8.0 milestone Apr 24, 2020
@skliper
Copy link
Contributor Author

skliper commented Apr 24, 2020

Forced push comments/doxygen updates to mark API's as deprecated

@skliper
Copy link
Contributor Author

skliper commented Apr 28, 2020

Rebased on master

@astrogeco
Copy link
Contributor

CCB 2020-04-29 : APPROVED

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB-20200429 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 8, 2020 18:03
@astrogeco
Copy link
Contributor

@skliper can you resolve the conflicts?

Removes untraced capabilities to decompress libraries or
apps on load.  For non-startup apps, FS can be used.  For
startup, recommendation is to compress/decompress as part
of boot/startup vs individual applications/libs at load.

Also fixes nasa#291, by deprecating decompress it can be moved
to the FS app.

Also makes nasa#135 N/A, static code analysis issues in decompress
@skliper skliper force-pushed the fix399-decompress-untraced branch from fec76a6 to 56e024c Compare May 8, 2020 20:42
@skliper
Copy link
Contributor Author

skliper commented May 8, 2020

@astrogeco conflicts resolved

@skliper skliper removed the conflicts label May 8, 2020
@astrogeco astrogeco merged commit d4d9130 into nasa:integration-candidate May 8, 2020
skliper added a commit to skliper/cFE that referenced this pull request May 11, 2020
@skliper skliper deleted the fix399-decompress-untraced branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB deprecate enhancement
Projects
None yet
2 participants