Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Fix #275, ES comment cleanup #671

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skliper
Copy link
Contributor

@skliper skliper commented May 5, 2020

Describe the contribution
Draft to consider for comment updates (remove end, remove function name)
Fix #275

Testing performed
None

Expected behavior changes
None

System(s) tested on
N/A

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 6.8.0 milestone May 5, 2020
@skliper
Copy link
Contributor Author

skliper commented May 5, 2020

Slightly simpler commenting pattern (remove function name comment, end function comment, EOF comment no longer really necessary) - looking for CCB suggestions or concurrence

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 6, 2020
/*
** Function: - See API and header file for details
*/
/* Gegister application - see API and header file for details */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@skliper skliper added CCB:Ignore Pull Request can be ignored. Will be re-examined at by next CCB. and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 6, 2020
@astrogeco
Copy link
Contributor

@skliper what did we agree to for this?

@skliper
Copy link
Contributor Author

skliper commented May 20, 2020

@astrogeco Just that the pattern was OK with the addition of an obvious delimiter. I'll work the real change in the future (leave as WIP/Draft).

@skliper skliper removed this from the 6.8.0 milestone Jul 27, 2020
@skliper skliper added this to the 7.0.0 milestone Aug 21, 2020
@astrogeco astrogeco closed this Oct 13, 2020
@astrogeco astrogeco reopened this Oct 13, 2020
@astrogeco astrogeco changed the base branch from master to main October 13, 2020 21:30
@astrogeco astrogeco marked this pull request as ready for review February 8, 2021 16:00
@astrogeco astrogeco marked this pull request as draft February 8, 2021 16:00
@astrogeco astrogeco closed this Jul 28, 2021
@skliper skliper reopened this Jul 28, 2021
@skliper skliper removed this from the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Ignore Pull Request can be ignored. Will be re-examined at by next CCB. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES comments need checked for consistency
3 participants