Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #706, Add location to push CTF scripts and plugins #709

Closed
wants to merge 1 commit into from

Conversation

dmknutsen
Copy link
Contributor

Describe the contribution
Fix #706
Adds locations to push CTF scripts and plugins

Testing performed
Steps taken to test the contribution:

  1. Ensured that the editor launches nominally
  2. Built and executed 3 test scripts

System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.13.0, OSAL 5.0.8.0, PSP 1.4.4.0

Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA/Goddard

ctf/README.md Outdated
Comment on lines 6 to 12
### Getting Started

To get started, clone the CTF repository using:

git clone git@aetd-git.gsfc.nasa.gov:gateway_cert/cfs_gw.git
cd cfs_gw
git submodule update --init

Note that the CTF repository must be cloned at the same directory level as the cFS repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't include the internal steps for the open source instructions. Open source steps would be to clone cFS and clone CTF from public repos.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And CTF hasn't been open source released yet... but leave as a TBD?

@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 19, 2020
@dmknutsen dmknutsen force-pushed the issue_706 branch 3 times, most recently from 7fb2f32 to 325f3a1 Compare May 20, 2020 14:05
@astrogeco
Copy link
Contributor

astrogeco commented May 20, 2020

CCB 20200520 - Move to a stand alone repository

@skliper skliper added CCB:Ignore Pull Request can be ignored. Will be re-examined at by next CCB. and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 20, 2020
@astrogeco
Copy link
Contributor

@dmknutsen do you need me to request the new repository under the NASA org or do you want to do it yourself?

@dmknutsen
Copy link
Contributor Author

@astrogeco Jake set one up last week. It is located here:
https://aetd-git.gsfc.nasa.gov/gateway_cert/cfe_bvt

@astrogeco
Copy link
Contributor

@astrogeco Jake set one up last week. It is located here:
https://aetd-git.gsfc.nasa.gov/gateway_cert/cfe_bvt

@skliper I thought we agreed to make it a github repo?

@skliper
Copy link
Contributor

skliper commented May 26, 2020

@astrogeco went local for simplicity for now, we can move to github later.

@skliper skliper added invalid and removed CCB:Ignore Pull Request can be ignored. Will be re-examined at by next CCB. labels May 26, 2020
@skliper
Copy link
Contributor

skliper commented May 26, 2020

Closing as invalid since it won't go in this repo

@skliper skliper closed this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants