fix #744 - update LastSender in pipe description and add AppId to buf… #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDKnightNASA
added
the
CCB:Ready
|
closing this PR, I feel the fix in #750 is more appropriate and holistic. |
CDKnightNASA
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
fix #744
This adds AppId to the buff description (used by
CFE_SB_GetLastSenderId()) and updates the LastSender field in the CFE_SB_PipeD_t struct for each pipe that receives the message.Testing performed
Built and ran in debugger to inspect values.
Expected behavior changes
Adds a field to the CFE_SB_SenderId_t struct, properly populates the CFE_SB_PipeD_t private struct (which is used for HK tlm.)
System(s) tested on
Debian 10.3
Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov