Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry GUI error - Individual telemetry pages do not open due to name errors in GenericTelemetry.py #202

Closed
ghost opened this issue Jan 18, 2022 · 0 comments · Fixed by #217
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Jan 18, 2022

Describe the bug
The Telemetry subsystem windows do not open anymore. When opening a telemetry window such as ES Housekeeping telemetry, it produces an error an error.

To Reproduce
Steps to reproduce the behavior:

  1. Start GroundSystem.py
  2. In the cFS Ground System Main Window, hit the "Start Telemetry System" button.
  3. In the Telemetry System Page Window, hit the "Display Page" button next to ES HK Tlm

In the console you will see:
NameError: name 'tlm_item_desc' is not defined.

I think the name convention change left a few old names in the file. From tlmItemDesc --> tlm_item_desc. See the Code snips section for all of the errors I found.

Expected behavior
Telemetry window should open, displaying packet values in the window.

Code snips
Look in cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py:

Line 71: tlmItemSize should be tlm_item_size
Line 79: tlmItemEnum should be tlm_item_enum
Line 82: tlmItemDesc should be tlm_item_desc
Line 90: gtSignalTlmDatagram should be gt_signal_tlm_datagram

Line 220: tlmItemDesc should be tlm_item_desc
Line 221: tlmItemSize should be tlm_item_size
Line 222: tlmItemFormat should be tlm_item_format

System observed on:

  • Hardware - Desktop PC
  • OS: Ubuntu 20.04
  • Versions: Using cFS main branch and associated submodules (1/15/2022)

Additional context
N/A

Reporter Info
Alan Cudmore NASA/GSFC

@ghost ghost added good first issue Good for newcomers bug Something isn't working labels Jan 18, 2022
paulober added a commit to paulober/cFS-GroundSystem that referenced this issue Jun 26, 2022
Sorry for that
dzbaker added a commit that referenced this issue Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants