Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Command definitions use '--word' option unrecognized by cmdUtil #40

Closed
skliper opened this issue Dec 5, 2019 · 2 comments · Fixed by #54
Closed

GUI Command definitions use '--word' option unrecognized by cmdUtil #40

skliper opened this issue Dec 5, 2019 · 2 comments · Fixed by #54
Assignees
Labels
bug Something isn't working
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Dec 5, 2019

Describe the bug
The command definitions in Subsystems/cmdGui/ParameterFiles use the --word option that gets reported as unrecognized by cmdUtil.

To Reproduce
Steps to reproduce the behavior:

  1. Build cmdUtil
  2. python GroundSystem.py
  3. Select "Display Page" for Executive Servies
  4. Select "Send" for "Load and Start an Application"
  5. Fill in StackSize with a 16384 and hit send, should see:
    ../cmdUtil/cmdUtil: unrecognized option '--word=16384'

Expected behavior
Cmd should work. cmdUtil expects --long instead of --word for an int32. Not clear if the GUI command definitions should be updated or the cmdUtil. Probably more useful to cal it int32...

Code snips

printf(" --long : Add a 32 bit parameter to the packet ( hex or dec )\n");

{ "long", required_argument, NULL, 'l' },

System observed on:

  • cFS Dev server
  • OS: Ubuntu 16.04
  • Versions: Current bundle (2.1.2 of cFS_GroundSystem)

Additional context
None

Reporter Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the bug Something isn't working label Dec 5, 2019
@skliper
Copy link
Contributor Author

skliper commented Dec 5, 2019

https://github.com/nasa/cFS-GroundSystem/blob/master/Subsystems/cmdGui/CHeaderParser.py and https://github.com/nasa/cFS-GroundSystem/blob/master/Subsystems/cmdGui/HTMLDocsParser.py autogenerate the command definitions and use "--word"

At some point this must have been changed just in cmdUtil. Need direction as to path forward.

@skliper
Copy link
Contributor Author

skliper commented Jan 8, 2020

CCB 20190108 - Update cmdUtil to use either (no strong feelings either way).

@dmknutsen dmknutsen self-assigned this Jan 8, 2020
dmknutsen added a commit to dmknutsen/cFS-GroundSystem that referenced this issue Jan 8, 2020
skliper pushed a commit to dmknutsen/cFS-GroundSystem that referenced this issue Jan 13, 2020
skliper added a commit that referenced this issue Jan 21, 2020
Fix #40, GUI Command definitions
@astrogeco astrogeco added this to the 2.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants