-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #104, Short term build fix for implicit endian functions #106
Fix #104, Short term build fix for implicit endian functions #106
Conversation
Integration candidate: 2020-05-20
Integration Candidate: 2020-05-27
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the original symbol _BSD_SOURCE_
(trailing underscore) was wrong, it is just _BSD_SOURCE
. That might be why it didn't work.
Also glibc says you shouldn't directly set internal __USE_BSD
symbol - this is computed by features.h based on _BSD_SOURCE
.
Recommend to remove __USE_BSD
and _BSD_SOURCE_
. Or I suppose it can be just merged as-is if we are confident that this is just a short term thing.
Thanks for looking into it. I'll update and retest. |
8d2e2f9
to
84c1756
Compare
Retested on both Ubuntu and CentOS w/ no build errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this is cleaner!
Describe the contribution
Quick temporary fix for implicit declaration of endian functions on some systems (RH/CentOs). Note the real fix will be #95, custom implementation of these functions and removal of the messy defines.
Fix #104
Testing performed
Built cleanly on CentOS (confirmed build error before change and error gone after)
Expected behavior changes
No build errors on CentOS
System(s) tested on
Additional context
#95 is real fix, this is a quick fix to avoid build errors
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC