Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Fix CommandSystem Attribute Error #114

Conversation

astrogeco
Copy link
Contributor

Describe the contribution
Fixes UI and backend mismatch caused in #96

Testing performed
Ran in Ubuntu VM

Expected behavior changes
Buttons work as expected

System(s) tested on

Additional context
See comments in #109

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Leor Bleir, NASA-GSFC

Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
Also removed the shareddata.py file; no longer needed
at this time
Issue with GUI, recompiled all .ui files
@astrogeco
Copy link
Contributor Author

@JandlynBentley-at-NASA can you test this fix to the issue we discussed yesterday?

Copy link

@JandlynBentley-at-NASA JandlynBentley-at-NASA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good.

@astrogeco
Copy link
Contributor Author

Closed, addressed by 08bcfb6

@astrogeco astrogeco closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants