Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #99, Guide format fix #117

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 27, 2020

Describe the contribution
Fix #99 - deletes old text file and fixes formatting of markdown

Testing performed
Viewed in GitHub. No code changes.

Expected behavior changes
Displays guide as expected.

System(s) tested on
GitHub

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC


$ yum install -y PyQt4 $ yum install -y qt qt-demos qt-designer qt4 qt4-designer

$ yum install -y PyQt4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pip3 install for PyQt and point it at PyQt5

$ yum install -y PyQt4 $ yum install -y qt qt-demos qt-designer qt4 qt4-designer

$ yum install -y PyQt4
$ yum install -y qt qt-demos qt-designer qt4 qt4-designer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use qt5 and qt5-designer.

$ yum install -y gcc-c++
$ wget <http://download.zeromq.org/zeromq-4.0.5.tar.gz>
$ tar xzvf zeromq-4.0.5.tar.gz
$ cd zeromq-4.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used pip3 install zmq

```
#### Running Ground System ###
```

$ python GroundSystem.py ```
$ python GroundSystem.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap for python3 GroundSystem.py

@astrogeco
Copy link
Contributor

CCB 2020-07-29, APPROVED

@skliper
Copy link
Contributor Author

skliper commented Jul 30, 2020

All good comments relative to the text, but if we really want to update these historical instructions I'd rather go with a python environment and requirements.txt or whatever other more automated method is appropriate. Shouldn't have to install by hand.

@astrogeco astrogeco changed the base branch from master to main July 30, 2020 20:28
@astrogeco astrogeco added the docs label Jul 30, 2020
@astrogeco
Copy link
Contributor

All good comments relative to the text, but if we really want to update these historical instructions I'd rather go with a python environment and requirements.txt or whatever other more automated method is appropriate. Shouldn't have to install by hand.

I'm fine leaving them as is since they're historical and we have the comment that they're outdated.

@astrogeco astrogeco merged commit 9b05270 into nasa:main Jul 30, 2020
@skliper skliper added this to the 2.2.0 milestone Aug 21, 2020
@skliper skliper deleted the fix99-guide-format-fix branch February 1, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Markdown for Ground System Guide
2 participants