Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #78

Merged
merged 1 commit into from
May 8, 2020
Merged

Fix typos #78

merged 1 commit into from
May 8, 2020

Conversation

pgrimaud
Copy link
Contributor

Hello,

This PR will fix :

  • 1 typo in RoutingService.py
  • 2 typos in Subsystems/cmdGui/CHeaderParser.py
  • 1 typo in Subsystems/cmdGui/CommandSystem.py
  • 1 typo in Subsystems/cmdGui/Parameter.py
  • 1 typo in Subsystems/tlmGUI/GenericTelemetry.py
  • 1 typo in Subsystems/tlmGUI/TelemetrySystem.py

Bye! 🤖

@skliper
Copy link
Contributor

skliper commented Apr 27, 2020

Thanks! Preference is to use the pull request template. Have you submitted a CLA (needed to accept an external contribution, just hand sign and email)?

See: https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Corp_CLA_form_1219.pdf or https://github.com/nasa/cFE/blob/master/docs/GSC_18128_Ind_CLA_form_1219.pdf

@skliper skliper added enhancement New feature or request pending CLA CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 27, 2020
@pgrimaud
Copy link
Contributor Author

Should I send CLA to GSFC-SoftwareRelease@mail.nasa.gov?

@skliper
Copy link
Contributor

skliper commented Apr 27, 2020

@pgrimaud Please do!

@pgrimaud
Copy link
Contributor Author

Email sent 👌

@skliper
Copy link
Contributor

skliper commented Apr 29, 2020

Confirmed CLA receipt

@astrogeco
Copy link
Contributor

CCB 2020-04-29 : APPROVED

@astrogeco astrogeco added CCB-20200429 CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 5, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 8, 2020 19:21
@astrogeco astrogeco merged commit 043a33d into nasa:integration-candidate May 8, 2020
@astrogeco astrogeco mentioned this pull request May 13, 2020
Merged
@skliper skliper added this to the 2.2.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.
3 participants
@pgrimaud @skliper @astrogeco