Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL Query Suites #372

Closed
3 tasks done
ArielSAdamsNASA opened this issue Oct 7, 2021 · 0 comments · Fixed by #373 or #371
Closed
3 tasks done

CodeQL Query Suites #372

ArielSAdamsNASA opened this issue Oct 7, 2021 · 0 comments · Fixed by #373 or #371

Comments

@ArielSAdamsNASA
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
CodeQL was failing due to a database error that lead to discovering the benefits of using query suites instead of calling queries from main.
github/codeql-action#430

I would generally recommend using a query suite instead of referencing the queries directly from github/codeql:main, because the query libraries on main are not guaranteed to exactly match the query libraries bundled with the cached copy of CodeQL on Actions. Using a query suite in this way ensures you get the queries and libraries straight out of the cached CodeQL instead.

Describe the solution you'd like
Use query suites such as jpl.qls for all queries.

Describe alternatives you've considered
Keep queries as is.

Requester Info
Ariel Adams, ASRC Federal

ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 8, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 8, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 8, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 12, 2021
astrogeco added a commit that referenced this issue Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant