Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force remove directory in codeql-reusable.yml #487

Closed
2 tasks done
havencarlson opened this issue May 18, 2022 · 1 comment · Fixed by #501
Closed
2 tasks done

Force remove directory in codeql-reusable.yml #487

havencarlson opened this issue May 18, 2022 · 1 comment · Fixed by #501

Comments

@havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
In codeql-reusable.yml, it should force remove a directory on line 97 so the script can continue if the directory doesn't exist.

To Reproduce

  1. Push to branch to run CodeQL
  2. Observe failed run if directory didn't exist

Expected behavior
If a directory doesn't exist before removing it, the script should continue

Code snips
rm -r ${{ inputs.component-path }} should be rm -rf ${{ inputs.component-path }}
codeql-reusable.yml

System observed on:
Browser

Additional context
None

Reporter Info
Full name and company/organization if applicable

@skliper
Copy link
Contributor

skliper commented Jun 7, 2022

Should this be marked as ready for review?

havencarlson added a commit to havencarlson/cFS that referenced this issue Jun 10, 2022
havencarlson added a commit to havencarlson/cFS that referenced this issue Jun 10, 2022
havencarlson added a commit to havencarlson/cFS that referenced this issue Jun 10, 2022
havencarlson added a commit to havencarlson/cFS that referenced this issue Jun 10, 2022
havencarlson added a commit to havencarlson/cFS that referenced this issue Jun 10, 2022
havencarlson added a commit to havencarlson/cFS that referenced this issue Jun 10, 2022
astrogeco added a commit that referenced this issue Jun 16, 2022
Fix #487, force remove old submodule directory in CodeQL workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants