Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #487, force remove old submodule directory in CodeQL workflow #501

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

havencarlson
Copy link
Contributor

@havencarlson havencarlson commented Jun 8, 2022

Checklist (Please check before submitting)

Describe the contribution
Fix #487, Force remove old submodule directory in CodeQL workflow

Testing performed
Steps taken to test the contribution:

  1. Update codeql-build.yml in another repo to use this workflow
  2. Push changes to the repo
  3. Verify codeql workflow ran

Expected behavior changes
no impact to behavior

System(s) tested on
Browser

Additional context
Add any other context about the contribution here.

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLAs apply to only software contributions.

@havencarlson havencarlson added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jun 8, 2022
@astrogeco
Copy link
Contributor

@havencarlson two small corrections:

  1. git rebase to remove the merge commit
  2. amend the primary commit to follow the Fix #XYZ standard

@skliper
Copy link
Contributor

skliper commented Jun 10, 2022

Minor nitpik/suggestion on improving the short description. How about Fix #487, Force remove old submodule directory in CodeQL workflow

@astrogeco
Copy link
Contributor

@havencarlson can you implement the suggestion above? If you'd like I can do the amend and force push

@astrogeco astrogeco changed the title Fix #487, fix rm in codeql workflow Fix #487, force remove old submodule directory in CodeQL workflow Jun 16, 2022
@astrogeco astrogeco merged commit e158073 into nasa:main Jun 16, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 22, 2022
@astrogeco
Copy link
Contributor

CCB:2022.06.15 APPROVED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB CCB:FastTrack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force remove directory in codeql-reusable.yml
3 participants