Fix #92, LGTM exclude generated files #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CCB 2020-07-29, APPROVED |
astrogeco
added
CCB:Approved
|
@skliper doesn't look like it worked. Maybe we can use the "file classifier" feature? |
|
You can see which files are evaluated by looking at the Files tab in the report |
|
@astrogeco I did use the "file classifier" feature. I suggest checking it into master to make sure it doesn't work. LGTM doesn't seem to always do full analysis on PRs. |
that's what I get for not looking at your file change :/ |
|
Just confirming this worked: |
PaulaBosca
pushed a commit
to McMasterNEUDOSE/cFS
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #92 - Exclude generated Ui_* python files from LGTM analysis (2nd try, #94 didn't work)
Testing performed
Submit yml script on LGTM and it still functioned, but doesn't provide enough information to tell if the exclusion worked. Requires an actual LGTM run.
Expected behavior changes
Exclude Ui*.py files from issue reporting
System(s) tested on
N/A
Additional context
#94 was the first attempt, didn't work.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC