Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59, Exclude LGTM False Positives #303

Conversation

ArielSAdamsNASA
Copy link
Contributor

@ArielSAdamsNASA ArielSAdamsNASA commented Jul 16, 2021

Checklist (Please check before submitting)

Describe the contribution
Fixes #59
Excludes cpp/string-copy-return-value-as-boolean

Testing performed
None

Expected behavior changes
No longer run against string-copy-return-value-as-boolean

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) enhancement labels Jul 16, 2021
@astrogeco
Copy link
Contributor

Do we want to exclude this for the whole analysis or just for sample_app? Also, is there a good way to maintain the github actions configuration aligned with the lgtm one?

@ArielSAdamsNASA
Copy link
Contributor Author

Also, is there a good way to maintain the github actions configuration aligned with the lgtm one?

github/codeql#6314

Thoughts?

@astrogeco
Copy link
Contributor

astrogeco commented Jul 21, 2021

CCB:2021-07-21 HOLD

Consider, pending and fixing directly in sample_app and sample_lib
https://lgtm.com/projects/g/nasa/cFS/alerts/?mode=tree&severity=error&ruleFocus=1507228686331

@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 21, 2021
@astrogeco astrogeco added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jun 7, 2022
@ArielSAdamsNASA
Copy link
Contributor Author

Closed: No longer using LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude lgtm false positives
3 participants