cFS Bundle Integration Candidate: Caelum+dev3 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrogeco
force-pushed
the
integration-candidate
branch
from
b092188
to
b7cbf8c
Compare
Renames workflows to better describe what each one does. The CodeQL "reusable" workflow is meant to be used by other workflows. The CodeQL "Analysis" workflow calls the "reusable" CodeQL workflow to execute the static analysis runs. Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
Fixes errors in CodeQL results uploads step. Update parameters in CodeQL "reusable" workflow. BREAKING Interface changes: - Renames callable workflow to `codeql-reusable.yml`, submodules will have to be updated - Adds required `component-path` input parameter - Repurpose tests input to be a boolean tied to "ENABLE_UNIT_TESTS" flag Internal changes: - Use git clone instead of checkout@v2 for the cFS-Bundle - Use symlink to map calling repo workspace to expected cFS Bundle directory location - Enable "code snippets" option to CodeQL Analyze action - Archives sarif files from analysis output - Removes code duplication by using a matrix build for security and coding standard analyses - Alphabetizes workflow inputs and order based on "required" flag
astrogeco
force-pushed
the
integration-candidate
branch
from
b7cbf8c
to
1864992
Compare
astrogeco
changed the title
Fix #412, git error in CodeQL Analyze Action
*cFE v7.0.0-rc4+dev70* nasa/cFE#2041, Improve CFE_SB_IsValidMsgId handler nasa/cFE#2034, Update CodeQL workflow nasa/cFE#2042, Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID *osal v6.0.0-rc4+dev32* nasa/osal#1209, typesafe definition of osal_id_t *sample_app v1.3.0-rc4+dev9* nasa/sample_app#165, Use preferred UT patterns Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Paul <paulober@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
astrogeco
force-pushed
the
integration-candidate
branch
from
1864992
to
267cb8a
Compare
astrogeco
added a commit
that referenced
this pull request
Feb 3, 2022
cFS Bundle Integration Candidate: Caelum+dev3
|
Had to do a force push to main, updated merge hash is f787d2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
PR #413
Also includes:
cFE v7.0.0-rc4+dev70
nasa/cFE#2041, Improve CFE_SB_IsValidMsgId handler
nasa/cFE#2034, Update CodeQL workflow
nasa/cFE#2042, Replace CFE_SB_ValueToMsgId(0) with CFE_SB_INVALID_MSG_ID
osal v6.0.0-rc4+dev32
nasa/osal#1209, typesafe definition of osal_id_t
sample_app v1.3.0-rc4+dev9
nasa/sample_app#165, Use preferred UT patterns
Testing performed
cFS Bundle Checks https://github.com/nasa/cFE/pull/2043/checks
cFE Checks https://github.com/nasa/cFE/pull/2043/checks
Note that CodeQL workflow will fail until #413 is merged into main branch. See passing test in that PR.
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 18.04
RTEMS 5
RTEMS 4.11
Additional context
See also nasa/cFE#2043
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@paulober
@jphickey