Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #457, Add build and run app reusable workflow #460

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 18, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Passed CI with modified workflow (pointed to skliper merge branch) here: https://github.com/skliper/CF/runs/6065276796?check_suite_focus=true

Expected behavior changes
None, CI only

System(s) tested on
CI

Additional context
None

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 18, 2022
@skliper skliper added this to the Draco milestone Apr 18, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2022
@astrogeco
Copy link
Contributor

CCB:2022-04-20 APPROVED with Changes

  • change don't skip from "push" to "pull request"

@skliper
Copy link
Contributor Author

skliper commented Apr 21, 2022

CCB:2022-04-20 APPROVED with Changes

  • change don't skip from "push" to "pull request"

Fixed in 0adfd3c, should be ready to merge.

@astrogeco astrogeco merged commit 325bf9e into nasa:main Apr 25, 2022
@skliper skliper deleted the fix457-build_run_workflow_reuse branch September 19, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reusable workflow for application build and run within bundle
2 participants