Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #656, do not use --force option on sarif conversion #657

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Mar 9, 2023

Checklist (Please check before submitting)

Describe the contribution
Removes use of --force option, which appears to have been removed in a recent update (4.1.0, dropped on 2023-03-07).

This option was only to overwrite an existing file but that should not be needed in a workflow that runs in a clean environment like this.

Testing performed
Run workflows

Expected behavior changes
No longer errors on this option.

System(s) tested on
Github workflow

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Looks like this option was removed in a recent update
@jphickey jphickey assigned jphickey and unassigned jphickey Mar 9, 2023
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 9, 2023
@chillfig chillfig added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 9, 2023
@dzbaker dzbaker mentioned this pull request Mar 13, 2023
2 tasks
@dzbaker dzbaker merged commit f28bab2 into nasa:main Mar 13, 2023
@jphickey jphickey deleted the fix-656-sarif-noforce branch April 4, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants