Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #173, Add executable install guide #175

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fix #173, Add executable install guide #175

merged 2 commits into from
Apr 21, 2021

Conversation

zachar1a
Copy link
Contributor

Describe the contribution
A clear and concise description of what the contribution is.

  • Adding executable installation instructions to Guide-GroundSystem.md

Additional context
Since a requirements.txt file is being added it could possibly simplify installs for future users by adding in the pyQT5 and the pyZMQ packages.

Contributor Info - All information REQUIRED for consideration of pull request
Zachary Gonzalez - Personal

@astrogeco astrogeco added CCB-READY CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) community and removed CCB-READY labels Mar 31, 2021
@astrogeco
Copy link
Contributor

Thanks for the PR!

@astrogeco astrogeco changed the title Fix 173 add executable install guide Fix #173, Add executable install guide Apr 7, 2021
@astrogeco astrogeco requested a review from zanzaben April 7, 2021 16:45
@astrogeco astrogeco added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 9, 2021
@astrogeco
Copy link
Contributor

My only qualm with this one is that the commit message is missing the "#" sign and capitalization. Everything else looks fine. I might add a note that this "depends" on #174.

@skliper skliper added CCB:2021-04-07 and removed CCB:Approved Indicates approval by CCB labels Apr 14, 2021
@astrogeco astrogeco changed the base branch from main to integration-candidate April 21, 2021 13:18
@astrogeco astrogeco merged commit ef41e91 into nasa:integration-candidate Apr 21, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 22, 2021
nasa/cFS-GroundSystem#174 update executable name and version in setup.py

nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 22, 2021
Combines:

nasa/cFE#1406
nasa/osal#967
nasa/cFS-GroundSystem#178

Includes:

nasa/cFE#1290, Split interface and implementation modules
nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing
nasa/cFE#1292, Remove testrunner and convert testcase to app
cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert.

nasa/osal#950, Eliminate time and access name collisions with VxWorks
nasa/osal#946, Fix Shell implementation on posix and rtems

nasa/cFS-GroundSystem#174, update executable name and version in setup.py
nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 22, 2021
Combines:

nasa/cFE#1406
nasa/osal#967
nasa/cFS-GroundSystem#178

Includes:

nasa/cFE#1290, Split interface and implementation modules
nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing
nasa/cFE#1292, Remove testrunner and convert testcase to app
cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert.

nasa/osal#950, Eliminate time and access name collisions with VxWorks
nasa/osal#946, Fix Shell implementation on posix and rtems

nasa/cFS-GroundSystem#174, update executable name and version in setup.py
nasa/cFS-GroundSystem#175, Add executable install guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants