-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #125, Standardize CI_LAB function names #126
Conversation
@@ -75,7 +75,7 @@ | |||
/* and acts accordingly to process them. */ | |||
/* */ | |||
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * **/ | |||
void CI_Lab_AppMain(void) | |||
void CI_LAB_AppMain(void) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
CHeaderParser.py uses ci_lab_msg.h to generate the CI_LAB_CMD binary which defines the commands that are listed in the Ground System display window for ci_lab. I had to update the list of command codes in ci_lab_msg.h (2nd commit in this PR) in order for CHeaderParser.py to generate the full list of commands in the CI_LAB_CMD binary. Without updating ci_lab_msg.h only the 2 command codes that were already listed in ci_lab_msg.h will be populated in the display window for ci_lab in the Ground System. After updating it, the CI_LAB_CMD binary seems to be generated correctly and the Ground System correctly displays all of the commands and runs them without error. If this change would be better as a separate issue, just let me know. |
@thnkslprpt CCB 20 October 2022: Approved pending workflow failure resolution (squash commits?) |
ab56985
to
f7b18c0
Compare
Squashed now @dzbaker |
f7b18c0
to
8944410
Compare
8944410
to
680d07c
Compare
Checklist
Describe the contribution
ci_lab_msg.h
in order for CHeaderParser.py to correctly generate the full list of commands in theCI_LAB_CMD
binary file.Also requires a change to the cfe startup script
A few files in the Ground System should also be updated to match the predominant convention.
Testing performed
Only GitHub CI workflow actions.
Expected behavior changes
No impact on behavior.
Contributor Info
@thnkslprpt